-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix script so it will work on windows #2
Conversation
setup.sh
Outdated
melos bootstrap | ||
echo Installing Melos $version via $exec | ||
|
||
$exec pub global activate melos $version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should always be dart, doesn't work properly with flutter activate for some reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really? it was broken before then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might not have run into the thing where it doesn't work, or it has been fixed, I thought that those two commands would be equivalent, but the flutter
one used to cause issues when activating melos before. On their site it also says dart
in the instructions. Maybe you could give some insight @Salakar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not got much thoughts on this sorry, I've always just done dart pub global activate
so may be why I've never seen issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reply! Maybe it's not even an issue anymore.
Apparently the PATH variable doesn't work well for windows' bash: ref
According to this thread the solution is just to run it via flutter/dart pub